[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix exception running gen-make.py

From: Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Date: Sun, 18 Aug 2013 22:58:09 +0900

> To further explain this consideration: even if both existence and
> permissions were checked, the code would *still* be wrong if args[0]
> were a directory. If an .isdir() check were added, the code would
> still be wrong if args[0] were a dangling symlink. And so on.
>
> Calling open() will detect all those potential problems.

Thank you for the commit.

But I think you should catch a exception which parser.readfp() throws,
and print approprite error mesage.

I think Users who don't know Python prefer an well-formatted
error message to stack trace.

Regards.

-- 
Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Received on 2013-08-18 15:58:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.