[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix exception running gen-make.py

From: Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Date: Sun, 18 Aug 2013 22:13:54 +0900

Daniel Shahaf wrote:
> I think that's the wrong fix. Input validation should be done by
> checking that the input is valid, not by ruling out every known invalid
> value.[1] In this case: by checking os.path.exists() at the point in the
> code that tries to interpret the argument as a filename.

Fixed in the attached patch.

Regards.

-- 
Masaru Tsuchiyama <m.tmatma_at_gmail.com>

Received on 2013-08-18 15:14:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.