[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add serf library version information to svn --version

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 15 Aug 2013 20:23:20 +0400

On Thu, Aug 15, 2013 at 8:07 PM, Ben Reser <ben_at_reser.org> wrote:
> On 8/15/13 4:48 AM, Ivan Zhakov wrote:
>> Thoughts?
>
> It'd be nice if this was printed under the linked dependencies section
> of `svn --version --verbose`, but I don't see a good way of adding that
> since serf is required by the dynamically loadable ra layer and isn't a
> core dependency.
>
> Maybe we should extend the ra layer vtable to provide a function to ask
> for linked libs to be added to that list. Since you're already talking
> about changing the vtable that would be the solution I would prefer.
>
> Shoving the version number of the library in the description doesn't fit
> with the existing behavior of our output and forces users of our library
> that want to find this information out to parse the description.
>
> That said I'd be fine with doing this in this manor for 1.8.x if we
> don't want to rev the vtable for it. It seems like a reasonable quick
> hack to get the information available.
>
I agree that using RA description for version information is not good
thing in general. But ra layer vtable is not solution also, because
printing dependencies done in libsvn_subr and libsvn_subr doesn't
depend on libsvn_ra. So I think we could stay with implemented
solution at least for 1.8.x.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-08-15 18:24:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.