[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add serf library version information to svn --version

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 15 Aug 2013 14:38:52 +0100

Ivan Zhakov <ivan_at_visualsvn.com> writes:

> On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin <philip_at_codematters.co.uk> wrote:
>> Philip Martin <philip.martin_at_wandisco.com> writes:
>>
>>> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>>>
>>>> Good point. I'll fix it in separate commit. What do you think about
>>>> patch itself?
>>>
>>> Is there any reason for the static optimisation? Does performance
>>> matter? Why not simply format each time?
>>
>> Ah! You don't have a pool.
>>
> Yes, that is the problem. But I think we can change vtable for RA
> layer since it's not part of our API?

Yes, the vtable is private and can be changed.

For the original patch an optimising compiler is allowed to reorder the
call to apr_snprintf and the assignment to description. However since
description_buf is static it will initially be all null so even if there
is a thread race the returned buffer should always be a null-terminated
string.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2013-08-15 15:39:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.