[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add serf library version information to svn --version

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 15 Aug 2013 16:07:40 +0400

On Thu, Aug 15, 2013 at 3:59 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>
>> Log message:
>> [[[
>> Add serf library version to svn --version output.
>>
>> * subversion/libsvn_ra_serf/serf.c
>> (RA_SERF_DESCRIPTION): Add version placeholders.
>> (ra_serf_get_description): Add serf library version information to RA layer
>> description.
>> ]]]
>>
>> Thoughts?
>
> I noticed today that the default user agent string produced by ra_serf
> is
>
> #define USER_AGENT "SVN/" SVN_VER_NUMBER " (" SVN_BUILD_TARGET ")" \
> " serf/" \
> APR_STRINGIFY(SERF_MAJOR_VERSION) "." \
> APR_STRINGIFY(SERF_MINOR_VERSION) "." \
> APR_STRINGIFY(SERF_PATCH_VERSION)
>
> so it's fixed at compile time. If I build against a serf shared library
> and then upgrade the serf library the default user agent remains at the
> old value. I think the user agent should use serf_lib_version as well.
>
Good point. I'll fix it in separate commit. What do you think about
patch itself?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-08-15 14:08:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.