[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] speed up svn_repos_authz_check_access

From: Roderich Schupp <roderich.schupp_at_gmail.com>
Date: Mon, 12 Aug 2013 09:54:57 +0200

On Sun, Aug 11, 2013 at 11:17 PM, Philip Martin
<philip.martin_at_wandisco.com>wrote:

> To see the difference consider an authz file with just one block for /.
> Given two paths, /foo/bar and /zig/zag, your patch produces two cache
> entries. Repeat requests for one of the paths pull the result directly
> from the cache. The cache grows without limit as further distinct paths
> are requested.
>

That's not how my patch works (the description could probably be more
explicit
about this aspect): we only cache the "result" of svn_config_enumerate2
if the given path corresponds to a block (section) in the authz file.
(Otherwise we don't call svn_config_enumerate2 at all and cache nothing.)
Hence the cache is limited by the size of the authz file (i.e. keys of
apt_hash_t svn_config_t->sections.

Cheers, Roderich
Received on 2013-08-12 09:55:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.