Re: [PATCH] add support for svnrdump to svn-backup-dumps.py
From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 8 Aug 2013 16:25:07 +0300
Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 22:17:05 +0900:
In the patch I reviewed, there was a
+ cmd = [ self.__svn_path, "youngest", self.__repospath ]
call a few lines above. I left it in the quoted context of my review.
>> Also, it'd be good practice to pass "--" in front of self.__repospath, but that
Indicating that further argv arguments are paths or URLs and not
> > ... and while at it, use r"" literals to avoid clashes with a
No, I worry about the Python language defining a meaning to the escape
inside a double-quoted string, just like it already defines
to be a newline character (and not literal backslash followed by literal
Thanks for the fixes.
This is an archived mail posted to the Subversion Dev mailing list.