[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] speed up svn_repos_authz_check_access

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 7 Aug 2013 17:59:16 +0400

On Wed, Aug 7, 2013 at 5:43 PM, Roderich Schupp
<roderich.schupp_at_gmail.com> wrote:
> Hi,
>
> revised patch attached, hopefully addressing all concerns.
>
> No more breaking encapsulation. We simply allocate svn_authz_t from the same
> pool
> that svn_config_t is allocated from and remember this pool in a new
> svn_authz_t
> member "pool".l Create a function authz_create() for that; it uses
> apr_pcalloc
> so that we don't have to explicitly zero members "cache" and "cached_user"
> any more.
>
Could you please provide log message for your patch submission [1]. It
makes reviewing patch much easier.

Did you consider make separate cache_pool and clear if we invoked with
different user?

[1] http://subversion.apache.org/docs/community-guide/general.html#patches

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-08-07 16:00:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.