Re: [PATCH] speed up svn_repos_authz_check_access

On Wed, Aug 7, 2013 at 11:07 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:

> > For example, when a client uses a long-lived keep-alive connection and
> > the authz file changes during the life of that connection, will your
> > change cause the changes to be picked up later than they would before
> > your patch?
> >
> We already cache authz in memory for connection. So this is not issue.

Yes. If the authz file changes on disk this will not be reflected in
svn_config_t
(because it is cached on the Apache connection) anyway.

If the USER changes between different request on the same connection
the cache will be purged. But that shouldn't happen anyway (except
for malicious requests using modified Subversion libraries).
There may also be other users of svn_repos_authz_check_access() besides
mod_authz_svn, but the only example in our tree is in the test suite and
that isn't affected.

Cheers, Roderich
Received on 2013-08-07 11:37:12 CEST