[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] speed up svn_repos_authz_check_access

From: Roderich Schupp <roderich.schupp_at_gmail.com>
Date: Wed, 7 Aug 2013 11:33:56 +0200

On Wed, Aug 7, 2013 at 11:05 AM, Philip Martin
<philip.martin_at_wandisco.com>wrote:

> It would probably better to introduce a new API something like:
>
> apr_pool_t *svn_config__pool(svn_config_t *);
>
> declared in subversion/include/private/.
>
> However I don't fully understand the logic governing the lifetime. The
> cache is part of svn_authz_t so I would expect it's lifetime to be that
> of svn_authz_t. If that's the case you add a pool member to svn_authz_t
> and use that.
>

Sorry, this patch has sat some time on my disk, so I can't remember why
I didn't implement your suggestion. I'll recheck where the pool that's
used in the creation of svn_authz_t originally came from.

I'll incorporate your other suggestions (esp. the infamous
svn_hash_{get,set}).

Cheers, Roderich
Received on 2013-08-07 11:34:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.