[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

From: Ben Reser <ben_at_reser.org>
Date: Tue, 6 Aug 2013 11:20:58 -0700

On Sat, Aug 3, 2013 at 5:36 PM, Masaru Tsuchiyama <m.tmatma_at_gmail.com> wrote:
> Hello
>
> I attach a patch to add support for svnrdump to svn-backup-dumps.py.
>
> [[[
> add support for svnrdump to svn-backup-dumps.py
>
> * tools/server-side/svn-backup-dumps.py
> () : fix comment
> () : update to ver 0.7
> () : import urlparse
> (SvnBackup.__init__) : fix message in SvnBackupException constructor.
> (SvnBackup.__init__) : check whether the second parameter is a local
> path or an URL.
> (SvnBackup.__init__) : check whether --deltas option is specified when
> the second parameter is an URL.
> (SvnBackup.__init__) : set svn and svnrdump paths.
> (SvnBackup.exec_cmd_nt) : open null device and pass it to Popen
> when printerr is False.
> (SvnBackup.get_head_rev) : rename this to get_head_rev_for_local.
> (SvnBackup.get_head_rev_for_url) : get HEAD revision for an URL.
> (SvnBackup.get_head_rev) : call get_head_rev_for_local for a local
> path, get_head_rev_for_url for an URL
> (SvnBackup.create_dump) : invoke svnadmin for a local path,
> svnrdump for an URL.
> () : fix help message.
> () : add --svnrdump-path and --svn-path.
> ]]]

I guess you don't need --non-interactive because standard input won't
be a terminal. But you need a way to set the --username/--password
args and maybe --trust-server-cert options to svnrdump.

Otherwise looks ok to me.
Received on 2013-08-06 20:21:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.