[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add 'svn:use-commit-times' property

From: Masaru Tsuchiyama <m.tmatma_at_gmail.com>
Date: Sat, 03 Aug 2013 20:44:04 +0900

> Use SVN_ERR_ASSERT instead.

I fixed this in the attached patch.

> The apr_time_now call looks odd. Do we need to change the file's
> timestamp in this case?

Do you think the file's fimestamp should be preserved afer removing the
property?

> You also need to update the help text for 'svn ps' to describe the new
> property, see subversion/svn/svn.c.

I fixed this in the attached patch.

> and "if (" not "if(".

I fixed this in the attached patch.

> svn diff -x-p
> , please? That makes review easier.

I fixed this in the attached patch.

> Inheriting could be a later patch. Another issue in the current patch
> is the use of apr_time_now when the property is removed; changing that
> affects the regression test.

I added a test in update_with_use_commit_times() at
subversion/tests/cmdline/update_tests.py.

Regards.

-- 
Masaru Tsuchiyama<m.tmatma_at_gmail.com>

Received on 2013-08-03 13:44:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.