[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1505121 - /subversion/trunk/build/generator/gen_base.py

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Fri, 2 Aug 2013 09:20:30 +0300

rhuijben_at_apache.org wrote on Sat, Jul 20, 2013 at 10:44:32 -0000:
> Author: rhuijben
> Date: Sat Jul 20 10:44:31 2013
> New Revision: 1505121
>
> URL: http://svn.apache.org/r1505121
> Log:
> * build/generator/gen_base.py
> (write_errno_table): Remove obsolete part of comment. On Windows we always
> required python and on other platforms we require python for generating the
> sql headers since 1.7.
>

The unix part wasn't and isn't obsolete. We require Python at autogen
time, but the comment said (correctly) that Python isn't required at
configure time.

> Modified:
> subversion/trunk/build/generator/gen_base.py
>
> Modified: subversion/trunk/build/generator/gen_base.py
> URL: http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_base.py?rev=1505121&r1=1505120&r2=1505121&view=diff
> ==============================================================================
> --- subversion/trunk/build/generator/gen_base.py (original)
> +++ subversion/trunk/build/generator/gen_base.py Sat Jul 20 10:44:31 2013
> @@ -244,9 +244,7 @@ class GeneratorBase:
> # ###
> # ### Currently it's only used by maintainer-mode builds. If this
> # ### functionality ever moves to release builds, it will have to move
> - # ### to configure-time. (But then you have to solve two problems:
> - # ### what to do on windows, and what to do on unix when Python is not
> - # ### available at configure-time.)
> + # ### to configure-time.
> import errno
> fd = open('subversion/libsvn_subr/errorcode.inc', 'w')
> fd.write('/* This file was generated by build/generator/gen_base.py */\n\n')
>
>
Received on 2013-08-02 08:21:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.