[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1508170 - in /subversion/trunk:

From: Daniel Shahaf <danielsh_at_apache.org>
Date: Wed, 31 Jul 2013 00:02:30 +0000

On Tue, Jul 30, 2013 at 03:56:02PM -0400, Greg Stein wrote:
> It really doesn't make that much of a difference. APR_HASH_KEY_STRING
> simply tells the hash function to watch for NUL rather than to
> traverse N characters. Because N doesn't have to be tracked, you might
> even argue the NUL-test is faster.
> IOW, passing APR_HASH_KEY_STRING does NOT perform a strlen(). So yes:
> a lot of this work isn't saving much at all.
> Just look at apr/tables/apr_hash.c:hashfunc_default()

svn_hash__make uses a hash function which does a strlen().

FWIW, I'm happy to do the actual removal / changes of code to implement
whatever the decision of this thread is.
Received on 2013-07-31 02:02:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.