[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN 1.7/1.8 "commit after delete" performance issue

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 30 Jul 2013 11:09:35 +0100

Alexander Lüders <alu_at_entimo.de> writes:

> Hi Philip,
>
> thanks for the response.
>
>> Passing the deleted file means that the path based optimisations are not
>> available in 1.7/1.8 and so svn_io_sleep_for_timestamps sleeps for
>> longer.

> That sounds like a fair assumption to me. Do you see any oportunity
> to implement some kind of optimization for the deletion case? Or is
> it something that cannot be fixed easily?

1.6 used svn_wc_get_actual_target but the current code no longer calls
that.

When we come to do the sleep for a single target that is not a working
copy root we need to use the parent directory when the target has been
deleted. I'm not sure what criteria we should use:

  - call svn_wc__node_is_not_present to detect status==not-present

  - svn_io_check_path to detect no detect kind==svn_node_none

  - svn_wc__is_wcroot to detect is_wcroot==FALSE

There is a similar problem with

   svn up wc/node

when the update removes 'node' although this case it's only an
inefficiency not a regression.

-- 
Philip Martin | Subversion Committer
WANdisco | Non-Stop Data
Received on 2013-07-30 12:10:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.