[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'svnadmin dump' is garbled on Japanese version of Windows.

From: Philip Martin <philip_at_codematters.co.uk>
Date: Thu, 25 Jul 2013 14:17:33 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> Masaru Tsuchiyama <m.tmatma_at_gmail.com> writes:
>
>>> Is that UTF-8? It's certainly UTF-8 in the email.
>>
>> No. It is Shift JIS.
>
> That is the problem. That string should be UTF-8. How does it get to
> be shift-JIS? The translations should be in UTF-8. Are you using old
> i18l tools?

Ah! I see. There are two UTF-8 to native conversions. It looks like I
did get r1485650 wrong. At the time I claimed:

> Those two lines are produced by different code paths. The first line
> is produced by repos_notify_handler:
>
> svn_error_clear(svn_stream_printf(feedback_stream, scratch_pool,
> _("Repository lock acquired.\n"
> "Please wait; upgrading the"
> " repository may take some time...\n")));
>
> The second line is produced by:
>
> SVN_ERR(svn_cmdline_printf(pool, _("\nUpgrade completed.\n")));
>
> and svn_cmdline_printf uses svn_cmdline_cstring_from_utf8 to do a UTF8
> to native conversion.
>
> So it appears the UTF8 to native conversion is missing from
> repos_notify_handler. I think repos_notify_handler should be using
> svn_stream_printf_from_utf8 rather than svn_stream_printf.

(http://svn.haxx.se/dev/archive-2013-05/0416.shtml)

but that seems to be wrong. I wonder why the user reported the original
problem?

-- 
Philip
Received on 2013-07-25 15:18:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.