[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1492651 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_repos/ subversion/svnadmin/ subversion/tests/cmdline/ tools/dist/

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 24 Jul 2013 16:32:07 +0200

On Wed, Jul 24, 2013 at 04:43:10PM +0400, Ivan Zhakov wrote:
> The call to svn_fs_verify_root() was just removed and never get
> called. That means that svnadmin @trunk doesn't perform FS specific
> filesystem checks for every revision.

Thanks. This should fix it.

[[[
* subversion/libsvn_repos/dump.c
  (verify_one_revision): Run svn_fs_verify_root() to ensure full
    verification of the revision.
]]]

Index: subversion/libsvn_repos/dump.c
===================================================================
--- subversion/libsvn_repos/dump.c (revision 1506445)
+++ subversion/libsvn_repos/dump.c (working copy)
@@ -1384,6 +1384,7 @@ verify_one_revision(svn_fs_t *fs,
                                             &cancel_edit_baton,
                                             scratch_pool));
   SVN_ERR(svn_fs_revision_root(&to_root, fs, rev, scratch_pool));
+ SVN_ERR(svn_fs_verify_root(to_root, scratch_pool));
   SVN_ERR(svn_repos_replay2(to_root, "", SVN_INVALID_REVNUM, FALSE,
                             cancel_editor, cancel_edit_baton,
                             NULL, NULL, scratch_pool));
Received on 2013-07-24 16:34:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.