[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1502539 - in /subversion/trunk: ./ subversion/include/svn_io.h subversion/libsvn_subr/io.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 22 Jul 2013 21:03:58 +0400

On Sat, Jul 13, 2013 at 2:36 PM, Stefan Fuhrmann
<stefan.fuhrmann_at_wandisco.com> wrote:
> On Fri, Jul 12, 2013 at 2:52 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>>
>> On Fri, Jul 12, 2013 at 4:48 PM, <stefan2_at_apache.org> wrote:
>> > Author: stefan2
>> > Date: Fri Jul 12 12:48:44 2013
>> > New Revision: 1502539
>> >
>> > URL: http://svn.apache.org/r1502539
>> > Log:
>> > Cherrypick merge c1442910,1443171,1481447,1493042 from the
>> > fsfs-format7 branch to /trunk and resolve a trivial tree conflict.
>> > This introduces a new seek() function with proper APR file buffer
>> > and read alignment that e.g. the fsfs-improvements branch needs.
>> >
>> Hi Stefan,
>>
>> Function svn_io_file_aligned_seek() doesn't look trivial. Could you
>> please add several test for this function? Thanks!
>
>
> Done in r1502770.
>
Thanks!

I've spend some time with profiling APR file buffered I/O and found
that APR doesn't work well in terms in performance in buffered modes:
APR always tries to read data after getting EOF to fill buffer. So may
be it's worth to create Subversion own svn_io__paged_access_t object
with own buffer and use unbuffered APR files?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-07-22 19:04:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.