Re: [PATCH] add sub command 'youngest' to svn [Was: Re: [PATCH] add sub command 'youngest' to svnrdump]
From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 22 Jul 2013 08:27:55 -0400
On 07/20/2013 02:42 AM, Masaru Tsuchiyama wrote:
Thanks for the patch. I didn't do a full review of it, but it looks as
* The patch introduces tab characters. Our project guidelines insist
* "SVN_ERR( svn..."
* I like the introduction of --no-newline, but the project is stingy
* Finally, you should ensure that the user passed exactly 0 or 1 targets
/* We want exactly 0 or 1 targets for this subcommand. */
/* Parse the first target into path-or-url. */
This is an archived mail posted to the Subversion Dev mailing list.