[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1502901 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 15 Jul 2013 16:36:33 +0400

On Sun, Jul 14, 2013 at 2:22 AM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Sat Jul 13 22:22:51 2013
> New Revision: 1502901
>
> URL: http://svn.apache.org/r1502901
> Log:
> Following up on r1502811, make ra_serf capable of reusing ra sessions after
> a log callback returns a SVN_ERR_CEASE_INVOCATION error, by properly resetting
> the connection in serf.
>
> In the location where I apply this change, we would have to read the remaining
> part of the request to make the ra-session reusable, while we already know that
> there are no more outstanding requests on the connection.
>
> * subversion/libsvn_ra_serf/util.c
> (svn_ra_serf__context_run_one): If the context loop returns a
> SVN_ERR_CEASE_INVOCATION error, reset the connection.
>
Hi Bert,

It looks like workaround for issue at wrong layer: I think serf should
automatically reset connection is this case.

Another question why reset connection only on SVN_ERR_CEASE_INVOCATION
error? What is the reason to leave session not reusable after other
errors?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-07-15 14:37:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.