[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1501207 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Fri, 12 Jul 2013 17:26:33 +0400

On Tue, Jul 9, 2013 at 3:57 PM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Tue Jul 9 11:57:46 2013
> New Revision: 1501207
>
> URL: http://svn.apache.org/r1501207
> Log:
> Stop ignoring xml parser errors in three places in ra_serf. These parse errors
> might be caused by broken network requests, or requests that should have had a
> body. In all cases ignoring the parser errors made true errors hard to detect.
>
> * subversion/libsvn_ra_serf/util.c
> (inject_to_parser,
> svn_ra_serf__process_pending,
> svn_ra_serf__handle_xml_parser): Properly handle xml parser errors.
>
[...]

> @@ -1485,14 +1487,24 @@ svn_ra_serf__process_pending(svn_ra_serf
> if (pending_empty &&
> parser->pending->network_eof)
> {
> + int xml_status;
> SVN_ERR_ASSERT(parser->xmlp != NULL);
>
> - /* Tell the parser that no more content will be parsed. Ignore the
> - return status. We just don't care. */
> - (void) XML_Parse(parser->xmlp, NULL, 0, 1);
> + /* Tell the parser that no more content will be parsed. */
> + xml_status = XML_Parse(parser->xmlp, NULL, 0, 1);
>
> apr_pool_cleanup_run(parser->pool, &parser->xmlp, xml_parser_cleanup);
> parser->xmlp = NULL;
> +
> + if (! parser->ignore_errors)
> + {
> + SVN_ERR(parser->error);
> +
> + if (xml_status != XML_STATUS_OK)
> + {
> + }
Hi Bert,

What is the purpose of this condition with empty body?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-07-12 15:27:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.