[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1501654 - in /subversion/branches/tristate-chunked-request/subversion: include/svn_config.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_ra_serf/util.c libsvn_subr/config_file.c

From: Ben Reser <ben_at_reser.org>
Date: Thu, 11 Jul 2013 17:16:42 -0700

On Wed, Jul 10, 2013 at 9:33 PM, Greg Stein <gstein_at_gmail.com> wrote:
> I don't think you want to do it this way.
>
> * keep the (now-renamed) "detect_chunking" flag separate, and in the
> session. it may be "local" to open() right now, but in the future it
> may be used as part of an operation's "first request"
>
> * detect_chunking remains a boolean, and it can be set to FALSE when
> the first probe is done (whether that is OPTIONS or a REPORT or...)
>
> * don't alter the probe or the request logic. it is fine. consider:
> - "auto": set detect_chunking, set using_chunked_requests
> - "yes": clear detect_chunking, set using_chunked_requests
> - "no": clear detect_chunking, clear using_chunked_requests
> In other words, you can get away with a simple change to serf.c for
> the "auto" work

Deleted the branch and redid it as described above. I do like this
implementation better.

See r1502401.
Received on 2013-07-12 02:17:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.