[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] overflow check in ra_serf + malfunction -> error

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 11 Jul 2013 16:35:40 +0400

On Thu, Jul 11, 2013 at 2:47 PM, Stefan Sperling <stsp_at_elego.de> wrote:
> I'd like to change an SVN_ERR_MALFUNCTION() in ra_serf into an
> error return, because aborting doesn't help with diagnosing problems.
>
> I also think that we should check for overflow in this case, since
> code further down depends on that not happening. Not very likely,
> since it's an off_t, but still.
>
> Is this patch correct?
>
> [[[
> * subversion/libsvn_ra_serf/util.c
> (svn_ra_serf__handle_xml_parser): Check for read_size overflow and
> return an EOF error in case of aborting the process.
> ]]]
>

A little bit side note, but all this retry and continue logic looks
broken me. Where is the guarantee that retried request has the same
response? I think connection close in middle of receiving response
should be considered as error.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-07-11 14:36:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.