[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1501163 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/checkout.c libsvn_wc/adm_files.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 9 Jul 2013 13:48:22 +0200

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_apache.org]
> Sent: dinsdag 9 juli 2013 12:44
> To: Bert Huijben
> Cc: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1501163 - in /subversion/trunk/subversion:
> include/private/svn_wc_private.h libsvn_client/checkout.c
> libsvn_wc/adm_files.c
>
> On Tue, Jul 09, 2013 at 12:25:33PM +0200, Bert Huijben wrote:
> > I haven't tested this, but this currently appears to remove the safety
net
> around:
> > $ rm trunk
> > $ svn co URL trunk
> > (which would produce an error and now two working copies)
>
> Why shouldn't it produce two working copies?
> The inner working copy is seen as an obstruction in the outer WC.
> I don't see why this would be a problem. It's a silly use case, but
> we don't need to strictly prevent it.
>
> > Or:
> > $ svn rm trunk
> > $ svn co URL trunk
> > (which will now produce two working copies, with the first partially
> obstructed)
>
> Same point as above.
>
> >
> > Or even:
> > $ svn up --set-depth excluded trunk
> > $ svn co URL trunk
>
> Same point as above.
>
> > In all these cases 1.6 would have behaved one way, and with single-db we
> behave in a different way as we don't just attach subdirectories in the
parent
> wc.db.
> >
> > This patch might fix a few use cases, but I don't think it solves a real
> problem... And it might create a whole heap of new propblems
> >
>
> Can you please suggest a better way of fixing the original issue then?

The proper fix would be:

Running 'svn cleanup'
Or fixing the reason why he needs to run 'svn cleanup.

Creating potentially obstructing working copies with less checking is never
a solution. Certainly not if we want to start storing multiple working
copies in a single wc.db file.

The error needs cleanup is an error that shouldn't be ignored: a user
encountering this error should fix his broken scenario, or we should fix the
reason why he needs to run cleanup.

        Bert
Received on 2013-07-09 13:49:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.