[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1500884 - /subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Mon, 8 Jul 2013 21:23:18 +0200

On Mon, Jul 8, 2013 at 9:03 PM, <gbg_at_apache.org> wrote:
> Author: gbg
> Date: Mon Jul 8 19:03:37 2013
> New Revision: 1500884
>
> URL: http://svn.apache.org/r1500884
> Log:
> On the --invoke-diff-cmd branch: Fix help string and comment.
>
> * subversion/svnlook/svnlook.c
>
> (options_table): Reverse the order and adjuste help strings for
> --invoke-diff-cmd and --diff_cmd, deprecating the latter.
>
> (main): Fix comment.
>
> Modified:
> subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c
>
> Modified: subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c
> URL: http://svn.apache.org/viewvc/subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c?rev=1500884&r1=1500883&r2=1500884&view=diff
> ==============================================================================
> --- subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c (original)
> +++ subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c Mon Jul 8 19:03:37 2013
> @@ -133,11 +133,11 @@ static const apr_getopt_option_t options
> {"no-diff-deleted", svnlook__no_diff_deleted, 0,
> N_("do not print differences for deleted files")},
>
> - {"diff-cmd", svnlook__diff_cmd, 1,
> - N_("use ARG as diff command")},
> -
> {"invoke-diff-cmd", svnlook__invoke_diff_cmd, 1,
> - N_("use ARG as diff command (see svn help diff for details)")},
> + N_("Customizable diff command (see svn help diff)")},
> +
> + {"diff-cmd", svnlook__diff_cmd, 1,
> + N_("deprecated, use --invoke-diff-cmd instead")},

I didn't realize you intended to deprecate --diff-cmd in favor of
--invoke-diff-cmd. Are you sure? I can see that they're related and
mutually exclusive, but not sure if they are direct "successors".

You made this change only for 'svnlook diff', but not for 'svn diff'.
Is that intentional, or just Work In Progress?

Does --invoke-diff-cmd support the "simple invocation style of
--diff-cmd" as well? I.e. can I do 'svnlook diff -r3 $REPOS
--invoke-diff-cmd /usr/bin/diff' and get the same result as with
--diff-cmd?

--
Johan
Received on 2013-07-08 21:24:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.