Re: svn commit: r1488693 - /subversion/trunk/subversion/bindings/swig/perl/native/Client.pm

On Sun, Jul 07, 2013 at 06:11:32PM +0300, Daniel Shahaf wrote:
> Roderich Schupp wrote on Sun, Jul 07, 2013 at 17:04:07 +0200:
> > On Sun, Jul 7, 2013 at 3:14 PM, Daniel Shahaf <danielsh_at_apache.org> wrote:
> >
> > > > - POD: Use modern sub parameter conventions in POD (no more
> > > "shift"ing).
> > >
> > > These all non-functional changes. We don't normally backport such changes
> > >
> >
> > There's a difference between Subversion proper and the (Perl, Python, Ruby)
> > bindings. The latter are useless without proper documentation,
>
> Nothing is useful without proper documentation, but devil's advocate
> says the bindings can be quite usable if you document only the delta
> between SVN::Client->info42 and svn_client_info42().
>
> > so IMHO the POD is "functional".

Never mind my previous response, I missed that the simple_prompt() sub was
part of POD, not part of code. So, yes, that one was a functional change.
Received on 2013-07-07 17:21:30 CEST