[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1499747 - /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 4 Jul 2013 23:51:50 +0200

> -----Original Message-----
> From: philip_at_apache.org [mailto:philip_at_apache.org]
> Sent: donderdag 4 juli 2013 15:22
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1499747 -
> /subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c
>
> Author: philip
> Date: Thu Jul 4 13:22:00 2013
> New Revision: 1499747
>
> URL: http://svn.apache.org/r1499747
> Log:
> Add a regression test for issue 4388.
>
> * subversion/tests/libsvn_wc/op-depth-test.c
> (check_db_actual): Reset statement on error.
> (move_update_parent_replace): New test.
> (test_funcs): Add new test.
>
> Modified:
> subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c
>
> Modified: subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_wc
> /op-depth-test.c?rev=1499747&r1=1499746&r2=1499747&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c (original)
> +++ subversion/trunk/subversion/tests/libsvn_wc/op-depth-test.c Thu Jul 4
> 13:22:00 2013
> @@ -1893,7 +1893,7 @@ check_db_actual(svn_test__sandbox_t* b,
> {
> const char *local_relpath = svn_sqlite__column_text(stmt, 0, b->pool);
> if (!apr_hash_get(path_hash, local_relpath, APR_HASH_KEY_STRING))
> - return svn_error_createf(SVN_ERR_TEST_FAILED,
> svn_sqlite__close(sdb),
> + return svn_error_createf(SVN_ERR_TEST_FAILED,
> svn_sqlite__reset(stmt),
> "actual '%s' unexpected", local_relpath);
> apr_hash_set(path_hash, local_relpath, APR_HASH_KEY_STRING, NULL);
> SVN_ERR(svn_sqlite__step(&have_row, stmt));
> @@ -1903,7 +1903,7 @@ check_db_actual(svn_test__sandbox_t* b,
> {
> const char *local_relpath
> = svn__apr_hash_index_key(apr_hash_first(b->pool, path_hash));
> - return svn_error_createf(SVN_ERR_TEST_FAILED,
> svn_sqlite__close(sdb),
> + return svn_error_createf(SVN_ERR_TEST_FAILED,
> svn_sqlite__reset(stmt),
> "actual '%s' expected", local_relpath);

Are these two changes related to the test? Or is this just fixing existing bugs?

        Bert
Received on 2013-07-04 23:52:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.