[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1499315 - in /subversion/branches/verify-keep-going/subversion: libsvn_repos/dump.c svnadmin/svnadmin.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 3 Jul 2013 16:36:15 +0200

> -----Original Message-----
> From: Daniel Shahaf [mailto:danielsh_at_elego.de]
> Sent: woensdag 3 juli 2013 13:38
> To: dev_at_subversion.apache.org
> Cc: commits_at_subversion.apache.org; prabhugs_at_apache.org
> Subject: Re: svn commit: r1499315 - in /subversion/branches/verify-keep-
> going/subversion: libsvn_repos/dump.c svnadmin/svnadmin.c
>
> prabhugs_at_apache.org wrote on Wed, Jul 03, 2013 at 10:49:02 -0000:
> > + notify_failure->warning_str = apr_psprintf(pool,
> > + _("E%06d: %s"),
>
> Would it make sense to push the E%06d: part down to the implementation
> of svn_err_best_message()?
>
> I.e., if the information is useful for this caller, presumably it'll be
> useful for others too?

No, not in the existing function. That is a breaking change to api users.

UI clients usually don't want to show things in the same way as 'svn'. They
might want to show it in different ways or want to include only parts of the
error if they recognize the error code. And if you go this way this is
impossible due to localization.

This sort of formatting belongs in svn_cmdline if it is shared between
commandline clients, not in the lower layers of the error api.

-----------
I don't see why '_("E%06d: %s"),' should be localized. I don't think it
really can be with just this string.

        Bert
Received on 2013-07-03 16:37:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.