[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1499315 - in /subversion/branches/verify-keep-going/subversion: libsvn_repos/dump.c svnadmin/svnadmin.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 03 Jul 2013 13:48:57 +0200

On 03.07.2013 13:37, Daniel Shahaf wrote:
> prabhugs_at_apache.org wrote on Wed, Jul 03, 2013 at 10:49:02 -0000:
>> + notify_failure->warning_str = apr_psprintf(pool,
>> + _("E%06d: %s"),
> Would it make sense to push the E%06d: part down to the implementation
> of svn_err_best_message()?
>
> I.e., if the information is useful for this caller, presumably it'll be
> useful for others too?

Error message formatting should not be the domain of libsvn_subr.
Different API consumers may want to format the error codes differently,
and it's a bad idea to make them parse it out.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-07-03 13:49:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.