[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: --rm-I alias to --remove-ignored

From: Konstantin Kolinko <knst.kolinko_at_gmail.com>
Date: Wed, 3 Jul 2013 02:22:54 +0400

2013/7/2 Daniel Shahaf <d.s_at_daniel.shahaf.name>:
> How about adding 'svn cleanup --rm-I' as a short option for 'svn cleanup
> --remove-ignored'?
>
> Currently we have --cl as a short option for --changelist, and in the
> past we decided not to add --sca as a short option for --show-copies-as-adds.
>
> #svn-dev asked me to post here before committing, so here.
>
>
> [[[
> Index: subversion/svn/svn.c
> ===================================================================
> --- subversion/svn/svn.c (revision 1498689)
> +++ subversion/svn/svn.c (working copy)
> @@ -393,6 +393,8 @@ const apr_getopt_option_t svn_cl__options[] =
> */
>
> {"cl", opt_changelist, 1, NULL},
> + {"rm-I", opt_remove_ignored, 0, NULL},

Is it actually an uppercase 'i' from 'ignored'? It looks a lot like
lowercase 'L'.
I'd better avoid mixing lowercase and uppercase character in an option name.

> + {"rm-?", opt_remove_unversioned, 0, NULL},

Beware that in a shell command line the '?' is the pattern that
matches any single character.

I think It does not lead to any real problems (as
a) this feature is for human users typing a command line and
encountering a matching filename is unlikely.
b) In a programmatic script somebody can always use the long option
name to avoid ambiguity),

but it looks unusual,

(A POSIX reference: see 2.6.6 Pathname Expansion and 2.13.1 Patterns
Matching a Single Character here:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
)

Best regards,
Konstantin Kolinko
Received on 2013-07-03 00:23:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.