[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [serf-dev] Re: ssl tunnel with basic authentication currently broken (was Re: Another crash in ra_serf in 1.8.0)

From: Lieven Govaerts <lieven.govaerts_at_gmail.com>
Date: Tue, 2 Jul 2013 22:36:22 +0200

On Wed, Jun 26, 2013 at 3:22 AM, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, Jun 25, 2013 at 5:43 PM, Lieven Govaerts
> <lieven.govaerts_at_gmail.com> wrote:
>>...
>> When playing around with 'KeepAlive Off' on the server, I noticed that
>> serf asks Subversion for the proxy credentials for every new
>> connection. Subversion stops with an authentication failed error after
>> the 4th connection, because it assumes the first 4 were all failed
>> attempts to authenticate.
>>
>> So, the application depends on serf caching the proxy credentials per
>> session/realm, and similarly the server creds per server/realm. I have
>> a WIP patch that improves credentials caching for Basic and Digest,
>> I'll try to finish that in the coming days.

This issue is fixed by r1983.

>
> Well... it seems you could also reset the counter upon a successful
> response. Or track it per-connection. [in the app, rather than in
> serf]
>
> Resetting the counter might be a bit easier than a new cache. (and
> defer the cache to future serf rev)

I've opted for a relatively simple cache, because I don't think serf
gives the application enough information to decide why the credentials
callback got called.

Lieven

>
> Cheers,
> -g
Received on 2013-07-02 22:37:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.