[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1498885 - /subversion/trunk/subversion/libsvn_delta/compat.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 02 Jul 2013 20:55:46 +0200

On 02.07.2013 19:59, Greg Stein wrote:
> On Tue, Jul 2, 2013 at 7:37 AM, <brane_at_apache.org> wrote:
>> Author: brane
>> Date: Tue Jul 2 11:37:54 2013
>> New Revision: 1498885
>>
>> URL: http://svn.apache.org/r1498885
>> Log:
>> Fix change initialization in the Ev2 compatibility shims.
>> The shims expect an uninitialized change record's kind to be svn_node_unknown,
>> but it was initialized to zero, which is svn_node_none.
> It used to be svn_kind_unknown. In the move to remove svn_kind_t, the
> zero value changed to svn_node_none.
>
> (I'm still not sure that adding a new value to svn_node_kind_t was a
> correct move; applications may freak out when they see a value they
> don't know)

This is from versioning.html, note "enumerated constants":

    Minor releases can introduce new functions, new symbolic and
    enumerated constants, and deprecate existing functions.

I was very careful to check that before introducing the the new
enumeration. It's not as if this is a new rule. (And yes ... I did weigh
the pros and cons of doing that. The cons included a choice between
revving half of our APIs, or keeping two distinct enumerations.)

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-07-02 20:56:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.