[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] default to expecting new FS backends to support \n in filenames

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 1 Jul 2013 13:52:08 +0200

On Mon, Jul 01, 2013 at 02:33:06PM +0300, Daniel Shahaf wrote:
> I don't remember whether I pointed this out when Stefan originally wrote
> that code:
>
> [[[
> * subversion/tests/libsvn_fs/fs-test.c
> (filename_trailing_newline): Switch from a blacklist approach to
> to a whitelist approach, for defining backends that don't implement
> the API correctly.
> ]]]

When a new backend comes along that doesn't handle \n due to a bug
in the design/implementation, this test is supposed to FAIL, not PASS!

So I would strongly prefer keeping a whitelist.
Received on 2013-07-01 13:52:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.