[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1497980 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 29 Jun 2013 15:31:42 -0400

On Sat, Jun 29, 2013 at 3:08 AM, Lieven Govaerts <svnlgo_at_mobsol.be> wrote:
> On Sat, Jun 29, 2013 at 5:17 AM, gstein_at_apache.org <gstein_at_apache.org> wrote:
>...
>> @@ -509,8 +503,14 @@ svn_ra_serf__open(svn_ra_session_t *sess
>> if (err && err->apr_err == APR_EGENERAL)
>> err = svn_error_createf(SVN_ERR_RA_DAV_REQUEST_FAILED, err,
>> _("Connection to '%s' failed"), session_URL);
>> + SVN_ERR(err);
>> +
>> + /* We have set up a useful connection. If we have a proxy AND it might be busted
>> + AND we switched to HTTP/1.1 (chunked requests), then probe the proxy. */
>> + if (serf_sess->using_proxy && serf_sess->busted_proxy && !serf_sess->http10)
>> + SVN_ERR(svn_ra_serf__probe_proxy(serf_sess, pool));
>
> This assumes the busted proxy is on the client's side, but that's not
> necessary the case. I'd drop the first condition.

Yup. Fixed in r1498012.

>...
> Missing from this patch is the instruction to the user to set the
> busted-prody flag. I don't have a test setup so I can test it, but
> from looking at the code it can be as simple as changing the error
> text in svn_ra_serf__error_on_status.

Right. I don't have a test setup either. I'm hoping Philip can help here.

Cheers,
-g
Received on 2013-06-29 21:32:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.