Re: 1.8.0 and mmap()

On 29.06.2013 10:09, NormW wrote:
> Hi All,
> Pardon for the noise.
> I could build all .c executables in 1.7.x (<=.10) but find the 1.8.0
> series has mmap(), which my now 'dated' OS does not have. Two files
> have the function, namely:

Let me guess ... Windows 95? (Or "98" or "Me" or whatever they wanted to
call it)

> libsvn_diff\diff_file.c,
> libsvn_subr\named_atomic.c
>
> The former is guarded by an #if !APR_HAS_MMAP substitute, while the
> second file does not; the question then 'is there (likely to be) a
> suitable alternate to use of mmap in named_atomic.c in the foreseeable
> future?' or have I arrived at the end of the branch?

Looks like it could be fixed, as the code does have an explicit check
for named atomic support; it just doesn't use the APR_HAS_MMAP flag as
well. Can you try the attached patch?

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com