[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1496127 - /subversion/trunk/subversion/tests/cmdline/checkout_tests.py

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 26 Jun 2013 09:42:22 +0100

Greg Stein <gstein_at_gmail.com> writes:

> We turn off the client sleeping for a second (via that crazy env var)
> during the test suite.

That doesn't affect this test. The timestamps involved are commit times
which are not limited by filesystem resolution but by internal clock
resolution.

> How about for this *one* test, we just insert: time.sleep(1)

We already have a 1.1s sleep. That's because the test was written using
timestamp manipulation that was limited to whole seconds. It was buggy
and I fixed it by getting the svn:date which has sub-second resolution.

I suppose we could increase the sleep to 2.1s and continue to use whole
second manipulations. I'm a bit reluctant to do that since the the
sleep is already the main contribution to runtime of checkout_tests.py
on my machine.

-- 
Philip Martin | Subversion Committer
WANdisco | Non-Stop Data
www.wandisco.com
Received on 2013-06-26 10:42:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.