On Tue, Jun 25, 2013 at 11:23 PM, Ben Reser <ben_at_reser.org> wrote:
> On Tue, Jun 25, 2013 at 11:17 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
>> Not by default perhaps, but we could do it by adding the same option
>> to 'svn diff' that you need for 'svnlook diff' for this to work:
>> C:\>svnlook help diff
>> --diff-copy-from : print differences against the copy source
> Why the heck not, if our commands aren't even consistent between
> svnlook and svn then we have a bug somewhere. We should fix the bug
> not add another option to change the behavior.
> Sure it might cause problems for some people, so we probably shouldn't
> change the behavior till 1.9, when we can point it out to people in
> release notes and it's part of their major upgrade.
Wow, wait a minute. Are you suggesting removing the (existing)
diff-copy-from option from 'svnlook diff'? Why? What's wrong with it?
It provides very useful functionality. I definitely use it for
post-commit mails, because it makes them much more focused on the
interesting diff portion. It's very clear in what it does, and it does
it well :-).
I see no inconsistency here. 'svnlook diff' simply has an option (a
very good one IMHO) that 'svn diff' doesn't have. And that option
happens to solve the issue at hand (albeit only for svnlook right now,
not for svn).
Received on 2013-06-25 23:30:24 CEST