[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 25 Jun 2013 14:41:00 -0400

On Tue, Jun 25, 2013 at 8:15 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> On Sun, Jun 23, 2013 at 3:43 AM, Greg Stein <gstein_at_gmail.com> wrote:
>> On Fri, Jun 21, 2013 at 11:36 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>>>...
>>> The fix seems to be pretty simple and could be safely backported (see
>>> patch). The only problem that probably we cannot backport addition of
>>> new configuration option due our backward compatibility policy. But
>>> may be I'm wrong.
>>
>> The SVN_CONFIG_OPTION_HTTP_FORCE_HTTP10 symbol cannot be added.
>> Anything using and compiled against that could not be compiled against
>> 1.8.0.
>>
>> But: we don't have to add the public symbol. We can certainly read/use
>> the config option in a 1.8.1 release.
>>
>> But as I said else-thread, I think we should only disable chunked
>> requests. Not force HTTP/1.0 completely. And call it busted-proxy :-)
>>
> I agree that force-http10 is not good name and semantic. Actually
> these proxies is not busted: it's allowed to HTTP/1.1 proxies to
> require content-length if they want. And strictly speaking proxies may
> have different behavior for different requests.

From *our* standpoint, they are busted. Subversion wants to use
chunked requests. If they don't support it, then they are busted.
Simple as that.

And we want to use a provocative name so that people understand
something needs to be *fixed*. Fixed for us because we view them as
*busted*.

> So I'm going to commit my patch with 'http-disable-chunked-requests'

That name does not signify that a problem exists which needs to be fixed.

-g
Received on 2013-06-25 20:41:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.