Re: svn commit: r1496434 - /subversion/trunk/subversion/svn/svn.c

Ivan Zhakov wrote:

> Julian Foad wrote:
>>>>> Log:
>>>>> * subversion/svn/svn.c
>>>>>   (svn_cl__check_cancel): Validate passed cancel baton for
>>>>>   better test coverage.
[...]
>> The code looks good but I don't understand the log message.  We
>> don't normally describe input validation as adding better "test
>> coverage".  Did you have something more specific in mind?  What
>> problem on dev@ is this related to?
>>
> It's not input validation. We were passing invalid cancel baton and
> found this issue only in TortoiseSVN. See r1495850:
> http://svn.apache.org/viewvc?view=revision&revision=r1495850
> http://svn.haxx.se/dev/archive-2013-06/0543.shtml

Thanks for explaining.  I have added this information to the log message.

- Julian
Received on 2013-06-25 18:10:31 CEST