[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Crash in TSVN with directory property conflict during update (was Re: Another crash in ra_serf in 1.8.0)

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 23 Jun 2013 16:29:59 +0200

On 23.06.2013 15:07, Lieven Govaerts wrote:
> Stefan,
>
>
> this issue is unrelated to ssl tunnelling or authentication, or more
> in general unrelated to ra_serf.
>
> The particular scenario here is a user updating a directory with both
> local property changes and incoming property changes. Svn then calls
> TSVN code to check if the user cancelled the action.
>
> Looking at the code, I noticed that the wrong baton is passed in the
> call to TSVN. The attached patch (to a 1.8.x wc) will fix that.
>
> I also noticed that svn command-line apparently does not use the
> cancel_baton, so this code path is never executed in our tests.
>
> Can you let us know if this patch fixes the issue for TSVN users?

I've tested your patch and it seems to work. I could reproduce the crash
using your described scenario. After applying the patch it doesn't crash
anymore and the debugger also shows that the Cancel() method is called
correctly.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
Received on 2013-06-23 16:30:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.