[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash showing log in 1.8.0

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 21 Jun 2013 20:25:24 +0200

Hi,

Another one from the crash reports:

in libsvn_client\log.c, line 715, function run_ra_get_log():

matching_segment = bsearch(&younger_rev, log_segments->elts,
                            log_segments->nelts, log_segments->elt_size,
                            compare_rev_to_segment);
SVN_ERR_ASSERT(*matching_segment);

The crash report indicates that 'matching_segment' is NULL, as 'bsearch'
can return according to the docs.

First problem: the SVN_ERR_ASSERT() is wrong since it tries to access
the returned pointer instead of checking the pointer itself:

SVN_ERR_ASSERT(matching_segment);

would be the correct way to do this.

The other problem is that the pointer actually is NULL and therefore the
assertion (if it was coded properly) would have triggered. Instead I now
get crash reports for this.
https://www.crash-server.com/Problem.aspx?ClientID=tsvn&ProblemID=26730

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
Received on 2013-06-21 20:25:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.