[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't validate properties during deletion.

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 21 Jun 2013 09:00:46 -0400

On 06/21/2013 06:43 AM, Daniel Shahaf wrote:
> I still think the logic better belongs inside svn_repos__validate_prop().
> (Not the least because it has three other callers which also need to
> accept NULL values.)
>
> --- subversion/libsvn_repos/fs-wrap.c (revision 1495373)
> +++ subversion/libsvn_repos/fs-wrap.c (working copy)
> @@ -172,6 +172,10 @@ svn_repos__validate_prop(const char *name,
> {
> svn_prop_kind_t kind = svn_property_kind2(name);
>
> + /* No property is mandatory. */
> + if (value == NULL)
> + return SVN_NO_ERROR;
> +
> /* Disallow setting non-regular properties. */
> if (kind != svn_prop_regular_kind)
> return svn_error_createf
>

+1. This is precisely what I was suggesting as well.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2013-06-21 15:01:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.