[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crashes in 1.8.0 test suite on Solaris Sparc (wrong alignment in cache_lookup())

From: Mattias Engdegård <mattiase_at_bredband.net>
Date: Fri, 21 Jun 2013 00:53:30 +0200

21 jun 2013 kl. 00.32 skrev Stefan Fuhrmann:

> After some IRC discussion, we added r1495209 which
> provides actual platform-independence.

With the messy code and extra htonl() call cost where not inlined, I
doubt it's worth it. I'd just #if out the 4-byte acceleration as
originally proposed (and apply the signedness fixes).

If you really want to keep the current code, I suggest moving the

     hash_value = hash_value * 0xd1f3da69 + val;

line outside the #if..#else..#endif section where it is currently
duplicated.
Received on 2013-06-21 00:54:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.