[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crashes in 1.8.0 test suite on Solaris Sparc (wrong alignment in cache_lookup())

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 20 Jun 2013 18:20:16 +0200

On Thu, Jun 20, 2013 at 08:13:14PM +0400, Ivan Zhakov wrote:
> On Thu, Jun 20, 2013 at 8:02 PM, Mattias Engdegård
> <mattiase_at_bredband.net> wrote:
> > 20 jun 2013 kl. 16.54 skrev Ivan Zhakov:
> >
> >
> >> It seems the code is missing #ifdef SVN_UNALIGNED_ACCESS_IS_OK . The
> >> attached patch should fix problem, but I'm not sure that this is right
> >> solution for the problem.
> >
> >
> > Assuming the hash function does not need to be portable (which appears
> > likely from a cursory look at the code), that fix is basically correct, if
> > you move out the assignment i=0 to right before the section you made
> > conditional. The following loop will complete the hash.
> > In other words, something like:
> >
> Yes, I missed "i = 0" assignment. Thanks for fixing.
>
> Stefan, I think Mattias is faster and prefer this approach actually.

Sure.

I just committed my fix because it helps, but won't stand in the
way of other fixes. I myself would let Stefan Fuhrmann make a final
decision on this.
Received on 2013-06-20 18:21:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.