[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crash when updating with 1.8

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 19 Jun 2013 20:22:47 +0000

Is this caused by the delayed open streams?


I don’t think this scenario was possible in 1.7.


Bert



Sent from Windows Mail



From: Stefan Küng
Sent: ‎Wednesday‎, ‎June‎ ‎19‎, ‎2013 ‎9‎:‎55‎ ‎PM
To: Subversion Development

Hi,

After the release of 1.8, the crash reports for TortoiseSVN are already
coming in.

Number one crash is during an update.

In libsvn_wc/update_editor.c, window_handler(), line 1012:

   if (err)
     {
       /* We failed to apply the delta; clean up the temporary file. */
 
svn_error_clear(svn_io_remove_file2(hb->new_text_base_tmp_abspath, TRUE,
                                           hb->pool));
     }

here the hb->new_text_base_tmp_abspath is NULL, which results later in a
null-pointer access exception.

Is it possible to get there without a temp file being created?

I suggest to check for this before trying to remove it:

   if (err)
     {
       if (hb->new_text_base_tmp_abspath)
         /* We failed to apply the delta; clean up the temporary file. */
 
svn_error_clear(svn_io_remove_file2(hb->new_text_base_tmp_abspath, TRUE,
                                             hb->pool));
     }


Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest interface to (Sub)version control
    /_/ \_\ http://tortoisesvn.net
Received on 2013-06-19 22:25:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.