Re: Divide by zero at subversion/libsvn_fs_fs/fs_fs.c:upgrade_pack_revprops() (was Re: SVN crach Log)

On Tue, Jun 18, 2013 at 6:53 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:

> On Tue, Jun 18, 2013 at 5:51 PM, Miliotis Nikolaos
> <NMiliotis_at_eurobank.gr> wrote:
> >
> > Hi,
> >
> > I have installed Subversion 1.8 and tried to upgrade the repository.
> During the upgrade it
> > produced the attached files.
> >
> > The command I used was:
> >
> > svnadmin –verify .
> > svnadmin –upgrade .
> Subversion crash (divide by zero) occur at
> subversion/libsvn_fs_fs/fs_fs.c:1481 in upgrade_pack_revprops()
> [[[
> static svn_error_t *
> upgrade_pack_revprops(svn_fs_t *fs,
> apr_pool_t *scratch_pool)
> {
> fs_fs_data_t *ffd = fs->fsap_data;
> const char *revprops_shard_path;
> const char *revprops_pack_file_dir;
> apr_int64_t shard;
> apr_int64_t first_unpacked_shard
> = ffd->min_unpacked_rev / ffd->max_files_per_dir;
> ^^^^^ zero!
>
> apr_pool_t *iterpool = svn_pool_create(scratch_pool);
> const char *revsprops_dir = svn_dirent_join(fs->path, PATH_REVPROPS_DIR,
>
> ]]]
>
> ffd->max_files_per_dir == 0 for some reason.
>

It's legal even for recent repository formats to not use sharding at all.
In that case, max_files_per_dir can actually be 0.

r1494287 fixes this issue (should be shipped of 1.8.1).

-- Stefan^2.
Received on 2013-06-18 22:37:50 CEST