[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1493272 - /subversion/trunk/subversion/libsvn_client/blame.c

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Sun, 16 Jun 2013 21:30:10 +0200

On Sat, Jun 15, 2013 at 12:43 AM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Fri Jun 14 22:43:09 2013
> New Revision: 1493272
>
> URL: http://svn.apache.org/r1493272
> Log:
> Revert r1446177, which tweaked the closing time of a blame stream.
>
> This patch caused a huge performance regression in some specific configuration
> triggered by the SharpSvn build.
>
> It also makes it clearer where we stop using the stream to help in applying the
> performance improvements I discussed today with jcorvel around reusing files
> instead of creating a tempfile for every new revision.

Bert,

Can you elaborate a bit? Why did this cause a huge performance
regression in some configurations (but not in others)?

Is this an important problem that might hurt other builds of 1.8.0?
Should this be backported in 1.8.1 or something?

--
Johan
Received on 2013-06-16 21:31:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.