Ben Reser wrote on Fri, Jun 14, 2013 at 14:09:29 +0200:
> On Fri, Jun 14, 2013 at 1:30 PM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> > Would it suffice to change the header file conditions from
> >
> > #if defined(DARWIN) || defined(DOXYGEN)
> >
> > to
> >
> > #if defined(DARWIN) || defined(DOXYGEN) || defined(SWIG)
>
> Yes and I guess that's probably the easiest solution for this older
> APIs. In 1.6. we introduced the platform specific APIs that make it
> easier to deal with runtime detection of platform specific auth
> runtimes. Given that I guess going back and mucking with the older
> APIs doesn't seem necessary to deal with the runtime issues.
>
> But in general outside of the existing auth cases we should avoid ever
> doing this again. We should simply design our APIs so that any
> platform specific ones have some sort of not implemented return for
> platforms where they are missing.
+1.
Perhaps we should have an _is_supported() function as well, e.g., an
svn_auth_kwallet_is_supported() would return FALSE on Mac and Windows.
Received on 2013-06-14 14:14:19 CEST