[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Fix for issue 4364

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Tue, 11 Jun 2013 13:19:35 +0200

Review of the formatting only (not of the patch substance):

Markus Schaber wrote on Tue, Jun 11, 2013 at 11:13:44 +0000:
> * subversion/libsvn_wc/adm_ops.c
> (process_committed_leaf): In the shortcut for deleted nodes, pass TRUE to remove the locks recursively.

Wrap to 80 chars please.

> @@ -240,6 +240,12 @@ post_process_commit_item(svn_wc_committed_queue_t
> + // When the node was deleted (or replaced), we need to always remove the
> + // locks, as they're invalidated on the server. We cannot honor the
> + // SVN_CLIENT_COMMIT_ITEM_LOCK_TOKEN flag here because it does not tell
> + // us whether we have locked children.

No C++-style comments. (They'll break the build.)

> @@ -1892,6 +1942,7 @@ test_list = [ None,
> locks_stick_over_switch,
> lock_unlock_deleted,
> commit_stolen_lock,
> + drop_locks_on_parent_deletion,

Use spaces, not tabs.

Cheers,

Daniel
Received on 2013-06-11 13:20:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.