[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: serf error handling for locks without authn

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 3 Jun 2013 20:01:50 -0400

On Mon, Jun 3, 2013 at 7:47 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
>...
> However there is another HTTP_UNAUTHORIZED: mod_dav_svn returns it from
> lock.c:refresh_locks:
>
> /* Sanity check: does the incoming token actually represent the
> current lock on the incoming resource? */
> if ((! slock)
> || (strcmp(token->uuid_str, slock->token) != 0))
> return dav_svn__new_error(resource->pool, HTTP_UNAUTHORIZED,
> DAV_ERR_LOCK_SAVE_LOCK,
> "Lock refresh request doesn't match existing "
> "lock.");
>
> I think this is a client sending the wrong lock token in an If: header,
> so perhaps "412 Precondition Failed" is correct here?

Yeah. That would work great.

Cheers,
-g
Received on 2013-06-04 02:02:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.